LiuzLab / TraceQC

Other
6 stars 1 forks source link

mutation_type function have a bug when running example_obj #18

Closed JasperYH closed 4 years ago

hyunhwan-jeong commented 4 years ago

Can you specify the bug?

JasperYH commented 4 years ago
> data(example_obj)
> mutation_type(example_obj)
Error: `breaks` and `labels` must have the same length
Run `rlang::last_error()` to see where the error occurred.
Called from: signal_abort(cnd)
JasperYH commented 4 years ago

I already know the reason. The diversity of mutation is low in dataframe example_obj$mutation

hyunhwan-jeong commented 4 years ago

Do you think we won't see the error when we execute the function on a real FASTQ file?

JasperYH commented 4 years ago

No, we won't. There are only 35 different types of mutations in the example_obj. Have you made any update to that object recently?

hyunhwan-jeong commented 4 years ago

I did some when I was fixing the index issue. Can you test using objects after execution of the below snippet?

data(example_obj_list)
obj <- example_obj_list$day14

Please test using the obj value.

JasperYH commented 4 years ago

It works well