search

LiuzLab / TraceQC

Other
6 stars 1 forks source link

Creating a function for an input object #8

Closed hyunhwan-jeong closed 4 years ago

hyunhwan-jeong commented 4 years ago

It would be great that TraceQC provides a function that specifies inputs, instead of putting each file path to an argument of a function.

The structure is going to be 

input_obj <- create_input_object(ref, fastq_files, ...)

, and we can access a path of each input like the following code snippet.

input_obj$ref # the path to the reference sequence file.
input_obj$fastq_files[1] # the path to the first fastq_files

I guess $ref can be a path or an object. The object contains a sequence and its information.

What do you think @JasperYH?

hyunhwan-jeong commented 4 years ago

@JasperYH, I saw your implementation, and I think we can include sequence_alignment to create_input_object. I am editing the function now.

hyunhwan-jeong commented 4 years ago

@JasperYH, Please review 019d6da351ccdcc63478afa10d649fb4204fdb74 and close this issue if you are fine with the changes. Otherwise, please put some comments!

Thank you,