Closed iojcde closed 3 years ago
I'm thinking of merging PR #9. With that PR contributing to the project is much easier. Might need to rebase after #9 is merged. Destack lib files are not changed in any major way so we need to add the changes to the new folder structure.
A few comments from a first glance:
.gitignore
is used for a local nextjs projectReadme.md
is already merged in.gitignore
ESBuild looks very promising and super fast. I'd have to perform more tests to ensure it's fine with previous versions of Node / Next.
Theoretically Destack works with any version Next.js that's >9.4. This PR is seems like a good opportunity to do more throughout compatibility tests.
Great!
Now that #9 is merged, I'll check tomorrow if it's still compatible.
Yep, the dev/ folder is the nextjs app for testing.
However, I might need your help removing the readme commit. I'm no git/github expert yet, and I have yet to figure out how to remove that commit from this pr.
I'm not git expert either but happy to help removing it.
Let me know when you get to setup the changes from the PR.
rebased for workspaces in #12
Esbuild is one of the fastest bundlers out there.
Switching to esbuild will mean faster builds while developing. It has built-in support for typescript, which will make migrating to typescript easier.
It's working well for me, but please test it out to see if it breaks anything.