LiveEnhancementSuite / LESforMacOS

Ableton Live, supercharged (on macOS)
https://enhancementsuite.me/
MIT License
142 stars 17 forks source link

Menu Item Limit #45

Open AvationMusic opened 9 months ago

AvationMusic commented 9 months ago

I updated my menu today and guess I exceeded 200 items with it. When I get low enough on the list, the search function breaks.

In my submenu "Saturators," there is an item "Waveshaper". When I select it, the item search proceeds as normal and the plugin loads perfectly. The item directly after "Waveshaper" is "Vitalizer" as per my menuconfig file. However, the menu in Ableton Live lists this item as "SPL Vitalizer MK2-T vst3". When I select this, the search query in Live reads "Bite". "Bite" is the item after "Vitalizer". So it appears that, at the "Vitalizer" item, the search query skips over its actual menu display name, and uses its search query as a menu display name instead. Thus, when that item is selected (with the incorrect display name) the search query is obtained from the next item. This causes a domino effect and breaks every item that follows. I.e. "Bite" is followed by "Dirt" in my menuconfig, yet when I try to load "Bite" using LES, "Dirt" is loaded instead.

To Reproduce

  1. Create a menu with over 200 items
  2. Select item 200
  3. Watch in disappointment as item 201 is loaded

Expected behaviour Menu display names from menuconfig would accurately transfer to the LES menu in Live. Additionally, when item 200 is selected, item 200 would be loaded.

Screenshots 1  Menu Config 2  Menu 3  Search Querry

OS & Version Info:

Additional context I understand that the macOS instance of LES is more difficult to maintain than the Windows counterpart, and this goes double for Apple Silicon Macs. Still, I just want to raise the issue as I think the observation about the behaviour could (hopefully) be insightful regarding how it skips over the 200th menu display name. Especially because the LES documentation states "The menu system for LES allows up to 2000 items" followed by "Please update if you run into the item limit," despite my even trying the latest beta. Just in case, I also tried running this all in Rosetta. The issue persisted.

Does LES for macOS just not support a menu of >200 items?

I will mess around with adding placeholders to see if I can brute force it to work again.

hypressi0n commented 8 months ago

It's not a bug, it's a problem on your side with the Menu text file. Firstly, change the search text exactly to (with 2 quotation marks and a dot before vst3):

Vitalizer (High End) "SPL Vitalizer MK2-T" .vst3

Secondly, make sure that you actually do have VST3 version installed (maybe it's not visible on Live or something).

hypressi0n commented 8 months ago

Ohh, seems like it happens because of WaveShaper actually, so apply same procedure to it as well.