search

LiveGTech / gShell

Interactive graphical desktop environment for LiveG OS.
https://liveg.tech/os
Other
15 stars 3 forks source link

[Snyk] Security upgrade electron from 16.2.0 to 17.4.8 #17

Closed tramcrazy closed 1 year ago

tramcrazy commented 2 years ago

This PR was automatically created by Snyk using the credentials of a real user.


Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.

![merge advice](https://app.snyk.io/badges/merge-advice/?package_manager=npm&package_name=electron&from_version=16.2.0&to_version=17.4.8&pr_id=6ec416f6-02d6-4eab-afea-ebd88bc5b8c2&visibility=true&has_feature_flag=false) #### Changes included in this PR - Changes to the following files to upgrade the vulnerable dependencies to a fixed version: - package.json - package-lock.json #### Vulnerabilities that will be fixed ##### With an upgrade: Severity | Priority Score (*) | Issue | Breaking Change | Exploit Maturity :-------------------------:|-------------------------|:-------------------------|:-------------------------|:------------------------- ![high severity](https://res.cloudinary.com/snyk/image/upload/w_20,h_20/v1561977819/icon/h.png "high severity") | **726/1000**
**Why?** Recently disclosed, Has a fix available, CVSS 8.8 | Use After Free
[SNYK-JS-ELECTRON-2870632](https://snyk.io/vuln/SNYK-JS-ELECTRON-2870632) | Yes | No Known Exploit ![medium severity](https://res.cloudinary.com/snyk/image/upload/w_20,h_20/v1561977819/icon/m.png "medium severity") | **539/1000**
**Why?** Has a fix available, CVSS 6.5 | Improper Input Validation
[SNYK-JS-ELECTRON-2932172](https://snyk.io/vuln/SNYK-JS-ELECTRON-2932172) | Yes | No Known Exploit (*) Note that the real score may have changed since the PR was raised. Check the changes in this PR to ensure they won't cause issues with your project. ------------ **Note:** *You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.* For more information: 🧐 [View latest project report](https://app.snyk.io/org/tramcrazy/project/f1757eb9-9ccb-45c2-9aab-ae054fc0e72c?utm_source=github&utm_medium=referral&page=fix-pr) 🛠 [Adjust project settings](https://app.snyk.io/org/tramcrazy/project/f1757eb9-9ccb-45c2-9aab-ae054fc0e72c?utm_source=github&utm_medium=referral&page=fix-pr/settings) 📚 [Read more about Snyk's upgrade and patch logic](https://support.snyk.io/hc/en-us/articles/360003891078-Snyk-patches-to-fix-vulnerabilities) [//]: # (snyk:metadata:{"prId":"6ec416f6-02d6-4eab-afea-ebd88bc5b8c2","prPublicId":"6ec416f6-02d6-4eab-afea-ebd88bc5b8c2","dependencies":[{"name":"electron","from":"16.2.0","to":"17.4.8"}],"packageManager":"npm","projectPublicId":"f1757eb9-9ccb-45c2-9aab-ae054fc0e72c","projectUrl":"https://app.snyk.io/org/tramcrazy/project/f1757eb9-9ccb-45c2-9aab-ae054fc0e72c?utm_source=github&utm_medium=referral&page=fix-pr","type":"auto","patch":[],"vulns":["SNYK-JS-ELECTRON-2870632","SNYK-JS-ELECTRON-2932172"],"upgrade":["SNYK-JS-ELECTRON-2870632","SNYK-JS-ELECTRON-2932172"],"isBreakingChange":true,"env":"prod","prType":"fix","templateVariants":["updated-fix-title","priorityScore","merge-advice-badge-shown"],"priorityScoreList":[726,539]}) --- **Learn how to fix vulnerabilities with free interactive lessons:** 🦉 [Learn about vulnerability in an interactive lesson of Snyk Learn.](https://learn.snyk.io?loc=fix-pr)
James-Livesey commented 2 years ago

I've now upgraded Electron anyway to V19, so I assume that the PR should close itself... If not maybe we should close these PRs manually if nothing happens in a few hours, seeing they're now redundant

James-Livesey commented 1 year ago

Updated to V22. @tramcrazy is there a way to get Snyk to re-scan deps and close these now-redundant PRs, or shall we just close them manually?

James-Livesey commented 1 year ago

I think it might have something to do with gShell not being in https://app.snyk.io/org/tramcrazy/projects so might need adding if possible, but we can remove AppRuntime and Neuron-old because they're not in use any more