search

LiveHelperChat / livehelperchat

Live Helper Chat - live support for your website. Featuring web and mobile apps, Voice & Video & ScreenShare. Supports Telegram, Twilio (whatsapp), Facebook messenger including building a bot.
http://livehelperchat.com
Apache License 2.0
1.96k stars 699 forks source link

Double escaping #1549

Closed ailaG closed 4 years ago

ailaG commented 4 years ago

Some strings seem to be escaped twice, and thus, at least in the Hebrew version, appear escaped to the user. Two such examples are

  1. The breadcrumbs at /index.php/site_admin/chatsettings/startchatformsettings , the last one should say צ'אט, but it says צ#039;אט instead. The title right under it ("Start Chat Form") is okay. lhc_esc1b

  2. The form the user gets when no operators are available, the e-mail field should say דוא"ל, but it says דוא"ל instead.

lhc_esc1

As a side note, the letters switching places is okay (דוא"ל vs דוא"ל, the letters on the left and the right are swapped) - this is okay, this is normal bidi behavior and is not a bug. The htmlentities are the bug.

remdex commented 4 years ago

Second one i could not reproduce. So most likely already fixed in some of the updates. image image

remdex commented 4 years ago

Managed reproduce and second one, reopened :D

remdex commented 4 years ago

Please update to master branch and all should be good after you clear a cache.