search

LivePersonInc / developer-center

LivePerson’s Developer Center and Community
https://developers.liveperson.com/
30 stars 199 forks source link

iOS docs outdated #339

Closed fgifford-liveperson closed 4 years ago

fgifford-liveperson commented 5 years ago
  1. In https://developers.liveperson.com/mobile-app-messaging-sdk-for-ios-quick-start.html

    let conversationViewParams = LPConversationViewParams(conversationQuery: conversationQuery, isViewOnly: false)

But according to XCode:

'init(conversationQuery:containerViewController:isViewOnly:conversationHistoryControlParam:)' was deprecated in iOS 3.8.0: Use public init(conversationQuery: ConversationParamProtocol, containerViewController: UIViewController? = nil, isViewOnly: Bool = false, conversationHistoryControlParam: LPConversationHistoryControlParam = LPConversationHistoryControlParam(historyConversationsStateToDisplay: .none), welcomeMessage: LPWelcomeMessage = LPWelcomeMessage(message: nil)) instead

  1. In https://developers.liveperson.com/mobile-app-messaging-sdk-for-ios-sdk-apis-monitoring-api.html#getengagement the parameter documentation is wrong: it's a copy/paste of the parameters for sendSDE.
EdenKupe commented 5 years ago

@randymclainLP can you take a look at this please?

EdenKupe commented 5 years ago

  1. Is being worked on internally, a fix is coming.

  2. I've been informed by Randy that these two methods are almost exactly the same and that there's no error.

fgifford-liveperson commented 5 years ago 
2\. I've been informed by Randy that these two methods are almost exactly the same and that there's no error.

This line is wrong: https://github.com/LivePersonInc/developers-community/blame/master/pages/documents/MessagingChannels/MobileAppMessagingSDKforiOS/Methods/monitoring%20methods.md#L43 it is a copy/paste of this line: https://github.com/LivePersonInc/developers-community/blame/master/pages/documents/MessagingChannels/MobileAppMessagingSDKforiOS/Methods/monitoring%20methods.md#L80.

The non-deprecated version of getEngagement is not identical to the deprecated version; it takes an identities parameter and not a consumerId parameter.

EdenKupe commented 5 years ago

Will relay this to Randy.

randymclainLP commented 5 years ago

This is helpful.. I'll add this to my pull request. Thanks for the clarification. Cheers.

randymclainLP commented 4 years ago

@EdenKupe can we close this issue?

EdenKupe commented 4 years ago

Certainly