LivePersonInc / dropwizard-websockets

MIT License
61 stars 28 forks source link

Allow endpoints to be registered during run() #3

Closed tsarna closed 8 years ago

tsarna commented 8 years ago

It would be nice if the endpoint classes could be registered in the application run() method, instead of having to be provided during initialize().

Among other advantages, this would allow them to be optional based on the configuration.

eitan101 commented 8 years ago

I intentionally tried to avoid this option in order to follow the way other bundles work, for example assets-bundle.

bucht commented 8 years ago

Changing this would make it a lot easier to get dropwizard's configuration into the endpoint to set properties on the session for example.

eitan101 commented 8 years ago

I added option to addEndpoint to the bundle from the run method. You can see it here.