search

LivePersonInc / node-agent-sdk

LivePerson Agent Messaging SDK for NodeJS
MIT License
49 stars 79 forks source link

Change WS domain connection to connect to facadeMsg instead of asyncM… #130

Closed map34 closed 3 years ago

map34 commented 3 years ago

…essagingEnt

akirilyuk commented 3 years ago

@map34 @asicath how did this got approved without a unit test?

asicath commented 3 years ago

@map34 @asicath how did this got approved without a unit test?

Its a config change, not a functional change. I'm not sure what sort of unit test you are looking for?

akirilyuk commented 3 years ago

@asicath well if you use now a different domain from the domains list to connect, then this should be also tested. An

Also this is a functional change since you are now using a different domain to connect.

A unit test would reflect that now the init method is called with the domain value stored in the facadeMsg instead of the asyncMessagingEnt property :)

otherwise I can change the domain property to something else and the tests would pass, however the your whole connection flow would be broken...