search

LivePersonInc / node-agent-sdk

LivePerson Agent Messaging SDK for NodeJS
MIT License
49 stars 78 forks source link

Unbind all WS events on close #76

Closed akirilyuk closed 5 years ago

tasoili commented 5 years ago

This looks good, and I appreciate the cleaning up!

Do you think it’s possible, though, to add some tests to the Transport class, especially to test the close and unbind?

We’re you able to manually test disconnecting and reconnecting?

akirilyuk commented 5 years ago

This looks good, and I appreciate the cleaning up!

Do you think it’s possible, though, to add some tests to the Transport class, especially to test the close and unbind?

We’re you able to manually test disconnecting and reconnecting?

Hi, I can add the tests.

Yes, I have tested the changes with our Bot-Connector. Everything worked as expected. Simulated network interruption etc and was able to reconnect.