search

LiveRamp / reslang

A language for describing resource-oriented APIs & turning them into Swagger or resource diagrams. Oriented around the concepts we want to expose in the APIs.
Apache License 2.0
23 stars 7 forks source link

Reslang generates topic names that are not terraform compatible. #126

Closed davinchia closed 2 years ago

davinchia commented 4 years ago

Reslang currently generated topic names with . in them.

Although this is pubsub compatible, this is not terraform compatible and causes errors.

cjea commented 3 years ago

@davinchia when I run terraform plan with a topic name of a.b/some-topic-name, the plan still succeeds. Were you only seeing errors once the plan was applied?

davinchia commented 3 years ago

I was seeing errors during the plan as well. Here's the specific error: https://github.com/LiveRamp/api-specs/pull/318#issuecomment-700881252

cjea commented 3 years ago

Oh, maybe this is due to the older terraform version (terraform0.12.20 in the linked comment). I think I'd rather update atlantis.yaml with a higher terraform version to see if that fixes the problem, before changing reslang output (since that would nuke + recreate infrastructure). I'll report back!

davinchia commented 3 years ago

Perhaps. Didn't look too much into this - can help out if needed. Just lmk on slack! Thanks!

cjea commented 3 years ago

@davinchia now that api-specs has terraform 0.12.29, would you mind checking if atlantis still runs into the same error on the auto-generated plan for topic names?

If the problem persists, we'll either need to update to terraform 13, or change the Reslang code