LiveRamp / reslang

A language for describing resource-oriented APIs & turning them into Swagger or resource diagrams. Oriented around the concepts we want to expose in the APIs.
Apache License 2.0
23 stars 7 forks source link

Use slash instead of dot to separate namespace #128

Open cjea opened 4 years ago

cjea commented 4 years ago

Issue: https://github.com/LiveRamp/reslang/issues/126

Use / instead of . to separate the namespace from the rest of the topic name.

Open questions:

~ name  = "rldb-customer-creation" -> "a/b/rldb-customer-creation" # forces replacement

EDIT: terraform plan doesn't complain about the DOT (.) separators either.

~ name  = "rldb-customer-creation" -> "a.b/rldb-customer-creation" # forces replacement

Maybe the above line does not guarantee that SLASH (/) is valid.

njaczko commented 4 years ago

Just a drive-by, haven't considered your other questions!

This is where you update the Reslang version: https://github.com/LiveRamp/reslang/blob/master/src/main.ts#L21

sonarcloud[bot] commented 4 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

cjea commented 4 years ago

Since this introduces a breaking change, it might be best not to merge this until we can get more fixes into the current major version. This puts us in a really tough spot.

ops-github-DU4JOAWE commented 4 years ago

This change is Reviewable