search

LiveRamp / reslang

A language for describing resource-oriented APIs & turning them into Swagger or resource diagrams. Oriented around the concepts we want to expose in the APIs.
Apache License 2.0
23 stars 7 forks source link

Iss 123/import ns with slashes #129

Closed cjea closed 3 years ago

cjea commented 3 years ago

Issue: https://github.com/LiveRamp/reslang/issues/123

Not sure if it was meant to be a restriction that only peer directories can be imported, but this PR would remove that restriction.

Not ready to merge. This PR would also allow ../ in the path, which shouldn't be a security concern, but worth flagging that reslang would be able to access any file on the filesystem (node's security story is pretty bad).

(merging into the ISS-126 branch to avoid diffs -- will update once this PR is ready for review)

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

cjea commented 3 years ago

Closing because reslang is working as intended (peer directories only). Allowing a / in the import path would be a new change, but not necessary right now