search

LiveRamp / reslang

A language for describing resource-oriented APIs & turning them into Swagger or resource diagrams. Oriented around the concepts we want to expose in the APIs.
Apache License 2.0
23 stars 7 forks source link

Fix broken imported subresources #135

Closed cjea closed 3 years ago

cjea commented 3 years ago

Resource parents array do not persist a resource's namespace. When trying to use an imported subresource, Reslang will try to parse that resource's parents. But the parent is not qualified with its namespace, so Reslang errors trying to find the definition.

This change is Reviewable

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

cjea commented 3 years ago

The real fix for this is to have reslang store parents correctly in the first place. This PR is just a hotfix, and should be fixed for real ASAP

ChristianHansen commented 3 years ago

Thanks for being on top of all of these.