search

LiveRamp / reslang

A language for describing resource-oriented APIs & turning them into Swagger or resource diagrams. Oriented around the concepts we want to expose in the APIs.
Apache License 2.0
23 stars 7 forks source link

MULTIDELETE generates openapi spec delete route with requestBody, which isn't supported #162

Closed steph0706 closed 3 years ago

steph0706 commented 3 years ago

High Priority

Describe The Bug when using MULTIDELETE, Reslang generates an openapi spec delete route with requestBody which isn't supported as noted in the HTTP RFC More context here: https://stackoverflow.com/a/54980985

To Reproduce Add MULTIDELETE operation to a Reslang resource and generate the openapi spec

Expected Behavior Generates working openapi delete route

Reslang Version

Master/Latest

njaczko commented 3 years ago

To clarify, Steph is referring to this error that gets presented in the online Swagger Editor when you attempt to render a spec with a MULTIDELTE with a request body:

Screen Shot 2020-10-28 at 2 23 22 PM

My gut reaction is that this is just a style warning - redoc seems to render such specs without complaining. I'll make sure our code-gen tools are work with this.

njaczko commented 3 years ago

As far as I can tell there's no problems with MULTIDELETEs having request bodies. It's just Swagger voicing an opinion. All of our tooling appears to be working fine! Feel free to re-open if something goes awry.