search

LiveRamp / reslang

A language for describing resource-oriented APIs & turning them into Swagger or resource diagrams. Oriented around the concepts we want to expose in the APIs.
Apache License 2.0
23 stars 7 forks source link

APIE-143 multiverb response id bug/subresource diagram background #243

Closed nathan-t-lr closed 2 years ago

nathan-t-lr commented 2 years ago

When using all multiverbs besides MULTIPOST don't return an id in the payload nested status objects. This is to fix that to make it synonymous with MULTIPOST. Additionally, I feel subresource instances should receive the same background as resource instances in the dotviz diagrams to differentiate them from the less significant structure instances.

ops-github-DU4JOAWE commented 2 years ago

This change is Reviewable

kmendo commented 2 years ago

This change is breaking the tests: Test Suites: 2 failed, 11 passed, 13 total Tests: 16 failed, 169 passed, 185 total

` ResourceB

id: intsize: int POST GET PUT>]; "v2/ResourceB" [label=<

v2/ResourceB
id: int
totalSize: int
POST GET
>]; "v2/ResourceB::Sub" [label=< - +
Sub
id: int
name: string
POST GET
>]; "v2/ResourceB" -> "v2/ResourceB::Sub" [dir="back" arrowtail="ediamond" label=< subresource >]; "ResourceA" -> "ResourceB" [label=< bId > arrowhead="vee"]; "ResourceA" -> "v2/ResourceB" [label=< newBId > arrowhead="vee"]; } 25 | console.log(got) 26 | } > 27 | expect(got).toBe(expected) | ^ 28 | } 29 | at compare (src/tests/dotviz.test.ts:27:17) at src/tests/dotviz.test.ts:10:9 at processTicksAndRejections (node:internal/process/task_queues:96:5)`
nathan-t-lr commented 2 years ago

This change is breaking the tests: Test Suites: 2 failed, 11 passed, 13 total Tests: 16 failed, 169 passed, 185 total

should be working now