diagram generation error (defective .dot file)

[j-q-arnold]

I have reslang that generates diagrams. One diagram omitted actions from a subresource. Investigating that, I believe the generated .dot file is defective. I'll attach the files.

./reslang /Users/jaarno/code/api-specs/segment-delivery --diagram segmentDelivery \
    --stdout >/Users/jaarno/code/api-specs/segment-delivery/generated-sources/segmentDelivery.dot

I tried a rules file with a larger maxResourceDepth, but that didn't change anything. So I started looking at the .dot file, and I think it is the problem. Issues I noticed:

• The reslang has actions with the same names attached to two different resources (one parent and one subresource). That seems to confuse the output. The subresource actions appear to overlay the actions on the top resource.
• Changing the subresource action names makes them visible in the graph, but they're attached to the resource and not the subresource. I think the generated digraph is defective on this point. Suggest using scoped names for the nodes, such as "SegmentDeliveryConfiguration::DeliveryConfiguration::Enable" instead of plain "Enable". The internal labels can be unadorned, but the node names need a fully scoped name to disambiguate.
• The .dot file appears syntactically incorrect. I don't see an error message from the web renderer, but it has multiple spurious "}. See lines 9, 12, 16, 20, 24, 28, 32, 36, 40 of segmentDelivery.dot.

I had to rename the files to make them acceptable attachments. Remove the .txt suffixes. The segment-delivery.reslang is the top-level file. See segmentDelivery-corrected.dot for a working output file.

segment-delivery.reslang.txt segmentDelivery.dot.txt types.reslang.txt diagrams.reslang.txt segmentDelivery-corrected.dot.txt

[liveandrew]

generates correctly on your example now. the issue was that i wasn't using a fully scoped name for drawing the arrows so it was getting confused!

[j-q-arnold]

I tried the latest reslang. The node names are fixed, but the spurious "} are still present. See the last bullet item in the original issue description.

Reopening this issue.

[liveandrew]

ah, ok, having a look

[liveandrew]

please try again, i've found a spurious }" string in the code and removed it

[j-q-arnold]

Better now. Thanks.