search

LiveRamp / reslang

A language for describing resource-oriented APIs & turning them into Swagger or resource diagrams. Oriented around the concepts we want to expose in the APIs.
Apache License 2.0
23 stars 7 forks source link

Make clipboard copy error non-fatal #84

Closed dimatkach closed 4 years ago

dimatkach commented 4 years ago

Fixes #79: when running on ubuntu (or docker container) without X, copy to clipboard fails resulting in a fatal error. Also fixes #82: when --stdout is present, do not attempt to clip. Fixing this by making the error non-fatal (warn and continue).

dimatkach commented 4 years ago

@cjea, @njaczko: good points!
I pushed another commit to address them. Would you please take another look?

dimatkach commented 4 years ago

Thank you guys for quick review. How do we get the docker image published with the new version?

njaczko commented 4 years ago

It looks like CloudBuild is supposed to be doing that. But, I'm not sure what GCP project that is running in or if it's actually working. I also don't know how new npm artifacts are built or pushed. @liveandrew is on PTO but @npoulallion has been attempting to figure out the release process.

njaczko commented 4 years ago

@dimatkach Update: found the successful cloudbuild build in liveramp-eng-api-dev so the new image should have been pushed!

https://console.cloud.google.com/cloud-build/builds/b77d7fbd-60da-4e39-a511-515ca609af97;step=2?project=liveramp-eng-api-dev

Still not sure about the npm releases though.