CryZe
commented
5 years ago This makes me wonder how much in general we want the Run to be able to influence the size of components. You can categorize all the layout settings in four categories:
- Does not affect the size of the component.
- Affects the size of the component directly (the setting's value is the influencing factor).
- Affects the size of the component by depending on per splits file data.
- Affects the size of the component by depending on per attempt information.
Right now almost all settings fall into the first two categories. We do have at least a single one that I can think of that falls into the third group and that's the amount of splits to visualize. You can set that to 0 and have it automatically choose the amount of segments in the run. We don't have any setting in the fourth group. Horizontal layouts are actually interesting in this regard, as we are doing estimations of horizontal width there and it's very easy to accidentally introduce estimations based on the latter categories there. The setting in question in this issue would fall into the third category. I'm certain we don't want to have any settings that fall into the fourth category, but the third is a grey area at the moment. We should come up with a decision on whether we want to allow settings of that category or not. (Or maybe there is some kind of warning when you use them?)
I'm not sure if this works out that well considering that means we'll have to change the height of the component based on the content. We'll probably have to bring in the Unicode Line Breaking Algorithm, which is implemented in xi-unicode.
Naegleria1 wants this: https://twitter.com/Naegleria1/status/1124160311173369856