LiveTL / android

LiveTL Android app.
https://play.google.com/store/apps/details?id=com.livetl.android
GNU Affero General Public License v3.0
33 stars 2 forks source link

Make the download button actually work #21

Closed KentoNishi closed 4 months ago

KentoNishi commented 3 years ago

Maybe provide functions for downloading text files and going fullscreen as native js interface methods?

arkon commented 3 years ago

For fullscreen, I can implement a JS interface method to toggle that.

For downloading stuff, would it pass strings of text to a JS interface method?

KentoNishi commented 3 years ago

For downloading text, I can just pass the string value (with newlines already included). For screenshots I can send a base64 encoded image url

arkon commented 3 years ago

Stubs for toggling fullscreen and downloading text added here: https://github.com/LiveTL/android/commit/05c8dc4c6211caf4524c650cab0face7511978e0

Let me know if the arguments aren't what you expected.

I'll follow up later on sharing images in #23.

KentoNishi commented 3 years ago

Perfect, I'll add it later

KentoNishi commented 3 years ago

@arkon small request: make toggleFullscreen accept no arguments. passing the boolean means tracking the FS state in the extension code rather than just triggering a toggle and that requires communicating FS exit events and such, so it would be much easier if it were just the toggle func. i'll implement it with that assumption in develop

KentoNishi commented 3 years ago

forgot another request: make the download text function accept the filename as the second parameter

arkon commented 3 years ago

Interface changes are done, and fullscreen toggling is hooked up (although not tested).

arkon commented 4 months ago

No longer relevant since not trying to use the extension anymore.