LiveTL / android

LiveTL Android app.
https://play.google.com/store/apps/details?id=com.livetl.android
GNU Affero General Public License v3.0
31 stars 2 forks source link

Pop out redirects #22

Closed KentoNishi closed 1 month ago

KentoNishi commented 2 years ago

Some buttons in the chat and player link to external URLs. Currently, the webview redirects to the selected page. Links should open in a new browser window instead.

arkon commented 2 years ago

Did the old app do stuff like this? WebView itself doesn't really have a concept of windows or tabs.

KentoNishi commented 2 years ago

The old app prevents navigation to other sites and opens all links in whatever browser the user has as default

arkon commented 2 years ago

I assume it was using this code? I don't know when the extension was calling it though.

KentoNishi commented 2 years ago

oh yea i think i had a recursive self-replicating snippet that injected itself into every frame and replaced links with that function lmao

KentoNishi commented 2 years ago

is there any way to intercept url changes? if it's a url outside of the android asset baseurl, u can just open it up in a new browser window

arkon commented 1 month ago

No longer relevant since not trying to use the extension anymore.