LiveUI / Awesome

FontAwesome 6 Swift & SwiftUI implementation for iOS, tvOS & macOS
MIT License
97 stars 27 forks source link

Fixes crash on loading fonts since FA 5.7.x #39

Closed ghowen closed 5 years ago

ghowen commented 5 years ago
ghowen commented 5 years ago

Love to. What do I need to do to release? Just change the version in the .podspec and create another PR?

For some reason cocoapods is still delivering the FA 5.5 fonts so something must have gone wrong with the 5.6 release. So I just want to get it right ;)

Thanks!

rafiki270 commented 5 years ago

yeah, that's it ... no idea what the issue with fonts might be ... have you cleared your xcode cache? Derived Data?

ghowen commented 5 years ago

Must be something with Cocoapods. They still show 2.0.1 as the most recent one although 2.0.2 should be there: https://github.com/CocoaPods/Specs/tree/master/Specs/e/b/d/AwesomeEnum. Do you need to tell Cocoapods somehow about an update or tag a release or something?

ghowen commented 5 years ago

OK, there are a few more steps involved https://sebastiandobrincu.com/blog/how-to-update-your-cocoapods-library-version and I am not sure if I have enough privileges to do them.

ghowen commented 5 years ago

OK, I did everything I can (I think) but I do not have the privileges to push. This must be done by @rafiki270 or @padarom.

padarom commented 5 years ago

I tried pushing, but I get this error:

λ pod trunk push AwesomeEnum.podspec
Updating spec repo `master`
warning: inexact rename detection was skipped due to too many files.
warning: you may want to set your diff.renameLimit variable to at least 14271 and retry the command.

CocoaPods 1.7.0.beta.1 is available.
To update use: `gem install cocoapods --pre`
[!] This is a test version we'd love you to try.

For more information, see https://blog.cocoapods.org and the CHANGELOG for this version at https://github.com/CocoaPods/CocoaPods/releases/tag/1.7.0.beta.1

Validating podspec
 -> AwesomeEnum (2.1.0)
    - NOTE  | xcodebuild:  note: Using new build system
    - NOTE  | xcodebuild:  note: Planning build
    - NOTE  | xcodebuild:  note: Constructing build description
    - NOTE  | xcodebuild:  warning: Skipping code signing because the target does not have an Info.plist file. (in target 'App')
    - ERROR | [OSX] xcodebuild: Returned an unsuccessful exit code. You can use `--verbose` for more information.

[!] The spec did not pass validation, due to 1 error.

Building in Xcode is no problem though.

rafiki270 commented 5 years ago

Hi Georg, could you please contact me on LiveUI slack so I can sort out access to the cocoapods for you too?

Sent from my iPhone 7+

On 4 Mar 2019, at 16:16, Georg von der Howen notifications@github.com wrote:

OK, I did everything I can (I think) but I do not have the privileges to push. This must be done by @rafiki270 or @padarom.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

ghowen commented 5 years ago

@padarom Hm, works for me with the exception of the missing privileges

CocoaPods 1.7.0.beta.1 is available.
To update use: `sudo gem install cocoapods --pre`
[!] This is a test version we'd love you to try.

For more information, see https://blog.cocoapods.org and the CHANGELOG for this version at https://github.com/CocoaPods/CocoaPods/releases/tag/1.7.0.beta.1

Validating podspec
 -> AwesomeEnum (2.1.0)
    - NOTE  | xcodebuild:  note: Using new build system
    - NOTE  | xcodebuild:  note: Planning build
    - NOTE  | xcodebuild:  note: Constructing build description
    - NOTE  | xcodebuild:  warning: Skipping code signing because the target does not have an Info.plist file. (in target 'App')

[!] You (xxx@xxx.xx) are not allowed to push new versions for this pod. The owners of this pod are xxx.xxx@xxx.xx and xx@xx.xx.

Or maybe I did not get far enough to receive that error message.

@rafiki270 I am on the LiveUI slack now and wrote something in the help channel. I am not so familiar with Slack yet so I hope this is good enough?

ghowen commented 5 years ago

@padarom Pushing worked for me now with the new privileges, so 2.1.0 is live on Cocoapods now.

padarom commented 5 years ago

Mhh odd, then maybe my toolchain isn't functional currently.