search

LiveUI / S3

S3 Client written in Swift
MIT License
93 stars 60 forks source link

Issue with RC tag names #16

Closed Joebayld closed 6 years ago

Joebayld commented 6 years ago

I may be wrong here - but why are all the tag names so inconsistent?

v3.0.0-rc2 3.0.0-RC3.0.1 3.0.0-RC3 3.0.0-RC2

Swift package manager doesn't like this.. I also don't think "v" should not be in the tag name either. rc2 shouldn't come after RC3.0.1. Thoughts?

For now, I'm just forking it and releasing a tag that works for swift PM.

rafiki270 commented 6 years ago

sorry :) ... fixed

Joebayld commented 6 years ago

Thanks! Also, I think the amount of digits should also be consistent moving forward. Example:

3.0.0-RC3.1.1 should never come after 3.0.0-RC3.1. To support 3 version numbers, it would be 3.0.0-RC3.1.0. But this works for now.