search

LiveUI / S3

S3 Client written in Swift
MIT License
93 stars 60 forks source link

Use URLSession directly, and disable caching for DELETE request #24

Closed zdnk closed 5 years ago

zdnk commented 5 years ago

Solves #19

zdnk commented 5 years ago

It passes the tests that I mention in issue #19 in my project. https://github.com/zdnk/vapor-filesystem/tree/0c25a686238a368446ff511376fee9c824f9c8fb

zdnk commented 5 years ago

I made the requested changes. Sorry for those smells, I just copied almost everything from FoundationClient.

rafiki270 commented 5 years ago

Please put the header back ... I know some people don't like them but they are all across our code ... plus it has been removed from just one file only leaving the rest of the codebase inconsistent

rafiki270 commented 5 years ago

also, would you mind contacting me on discord? @rafiki270

zdnk commented 5 years ago

also, would you mind contacting me on discord? @rafiki270

I did :)

zdnk commented 5 years ago

Please put the header back ... I know some people don't like them but they are all across our code ... plus it has been removed from just one file only leaving the rest of the codebase inconsistent

Done