search

LiveUI / S3

S3 Client written in Swift
MIT License
93 stars 60 forks source link

Fixed Presigned URLs #28

Closed Joebayld closed 5 years ago

Joebayld commented 5 years ago

The issue was that the AWS query keys are case sensitive. Making this match the documentation fixed it.

rafiki270 commented 5 years ago

@Joebayld would you like to do a release?

Joebayld commented 5 years ago

@rafiki270 Let's hold on releasing this.. There's another way to create a presigned URL that would be more elegant. It allows you to pass a signature through query params instead of a auth header.

I'll try to get a PR going soon.

rafiki270 commented 5 years ago

@joebayld I would prefer to release a bug fix asap and do a minor update later whenever you might be ready with it tbh

Joebayld commented 5 years ago

Fair enough!

The other bug I came across is if you have queries in the URL that you want to presign, it won’t work. It doesn’t work because the queries need to get signed in the canon string.

On Tue, Nov 13, 2018 at 4:26 AM Ondrej Rafaj notifications@github.com wrote:

@Joebayld https://github.com/Joebayld I would prefer to release a bug fix asap and do a minor update later whenever you might be ready with it tbh

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/LiveUI/S3/pull/28#issuecomment-438195891, or mute the thread https://github.com/notifications/unsubscribe-auth/AI9sFfjOgK31Ad38iXijK8OgNIIObPfJks5uupArgaJpZM4YY9pt .