Grabbing a morph triggers dragging

LivelyKernel / LivelyKernel

The Lively Web runtime and development environment

http://lively-web.org/

MIT License

296 stars 60 forks source link

Grabbing a morph triggers dragging #273

Open athomschke opened 10 years ago

athomschke commented 10 years ago

onDrag is initiated when grabbing a morph. Also, grabbing is falsly implemented by setting world.draggedMorph (or now hand.draggedMorph), and only then a morph will be grabbed. The correct implementation makes a clear difference between grabbing and dragging. However, this problem has existed for quite a while now (it also exists in lively-kernel), so there might be morphs relying on this bug :(

levjj commented 10 years ago

I ran into this problem a couple of times. Dragging and grabbing a morph are two completely different behaviors and should not be implemented on top of each other. Maybe it makes sense to introduce a new method like mouseHoldMove(evt) with dragging and grabbing as two alternative implementations (depending on a flag set initially).

rksm commented 10 years ago

@athomschke Actually the fix we committed on Friday to lively-web.org seems to work OK. I think this can be committed but please check the menu issue (which is not related to the dragging stuff). Thanks!