LivelyKernel / lively.modules

JavaScript package and module system for interactive development
8 stars 1 forks source link

Invoke mocha-es6 in a Windows-compatible way. #38

Closed binki closed 7 years ago

binki commented 7 years ago

npm test automatically adds the node_modules/.bin directory to PATH and npm install automatically creates .cmd stubs for binaries from projects. Trying to directly execute a file with a shebang does not work on Windows. The portable way to invoke mocha-es6 is actually more concise than the original non-portable method.

binki commented 7 years ago

Please let me know if the failed Travis CI build was actually introduced by this change. From a quick glance, I think the test failure is unrelated to this simple change.

rksm commented 7 years ago

Mysterious, I'll check.

rksm commented 7 years ago

All good, seems to have been a travis hiccup. Thanks for the patch!