LivelyKernel / lively.morphic

An implementation of the Morphic user interface framework for lively.next.
13 stars 2 forks source link

scroll does not affect morph position / bounds #119

Closed rksm closed 7 years ago

rksm commented 7 years ago

This seems to have been introduced in the recent transform refactoring 89f2f1a70c7395fd4673cecde61a3746d9884b0f

screen shot 2017-02-03 at 11 08 05 pm

To reproduce:

import { morph } from "lively.morphic";
import { Color, pt } from "lively.graphics";
var m = morph({
  clipMode: "auto", extent: pt(100,100),
  fill: Color.red,
  scroll: pt(10,10),
  submorphs: [{
    position: pt(20,20),
    extent: pt(100,100),
    fill: Color.green,
  }]
}).openInWorld()
m.world().showHaloFor(m.submorphs[0])

There is actually a test that fails since the mentioned commit! $world.execCommand("open browser", {packageName: "lively.morphic", moduleName: "tests/rendering-tests.js", textPosition: {column: 0,row: 130}}); when run locally in non-nodejs environments

merryman commented 7 years ago

Fixed since 7f8303b90b7cd9565a3653ee5a747333777772f1 I think.