search

Living-with-machines / TargetedSenseDisambiguation

Repository for the work on Targeted Sense Disambiguation
MIT License
1 stars 0 forks source link

NN BERT baseline (Hu et al., 2019) #44

Closed kasparvonbeelen closed 3 years ago

kasparvonbeelen commented 3 years ago

Replicate method of (Wiedemann et al., 2019) and (Hu et al., 2019) as disambiguation baseline.

kasparvonbeelen commented 3 years ago

I hope this is done. I tried to replicate the code from Hu et al 2019 and fit it in the evaluation framework. Paper: Hu, R., Li, S., & Liang, S. (2019). Diachronic Sense Modeling with Deep Contextualized Word Embeddings: An Ecological View, 3899–3908. https://doi.org/10.18653/v1/p19-1379
 -

Maybe @fedenanni can you have a look?

fedenanni commented 3 years ago

@kasra-hosseini if you have a bit of time in the next days, could you take a look at this? I am finishing the provenance PR with Mariona at the moment, otherwise max early next week I can go through this one

fedenanni commented 3 years ago

I think we need first to merge the provenance PR as this one includes some changes that are actually part of the provenance (the download scripts in utils). Just to avoid reviewing twice the same code

kasparvonbeelen commented 3 years ago

I think we need first to merge the provenance PR as this one includes some changes that are actually part of the provenance (the download scripts in utils). Just to avoid reviewing twice the same code

@fedenanni Yes, this builds on the output of the data produced by the Provenance PR (but there is no overlap I can think of, i.e. no download script in utils).

fedenanni commented 3 years ago
Screenshot 2020-11-18 at 14 42 39

Sorry, I just meant that this PR would modify (by deleting) the download script in utils

kasparvonbeelen commented 3 years ago

It should be possible to run the scripts in #45 with the quotation_all_machine_nn01.pickle file on SharePoint. I may have a made a mistake with linking the PR to branch, which 44-kNN-BERT-baseline. But this can wait of course.

kasparvonbeelen commented 3 years ago

Sorry, I just meant that this PR would modify (by deleting) the download script in utils

Ah yes, sorry for that. I hope it won't delete the download file on dev after merging? I just removed it, as it is not part of the current PR.

fedenanni commented 3 years ago

Eheheh don't worry! In the current setting it would, but we can rebase this branch right after we have merged the Provenance into Dev, so you will be completely aligned with dev apart from the new KNN changes - it's going to be fun!

kasparvonbeelen commented 3 years ago

Looking forward :-) .

kasra-hosseini commented 3 years ago

@fedenanni Sorry for the delay. I will review this today.

fedenanni commented 3 years ago

@kasra-hosseini hey! don't worry at all!