Closed griff-rees closed 1 year ago
Looks like I need to alter everything to python>=3.7
, will update you on that when it's ready.
From an AAAH perspective important that the walkthroughs/demos with the dummy files work. I tried running the demo in the documentation (see demo.md
) and those instructions are out of date.
pip install alto2txt
needs to replace pip install -r requirements.txt
./extract_publications_text.py -p single demo-files demo-output
needs to be changed to src/alto2txt/extract_publications_text.py
Hey @LydiaFrance: thanks for the comments. I'm hoping my recent commits addresses that, another review would be great.
Hi @LydiaFrance and @andrewphilipsmith. I haven't reached all the goals for version
0.3.4
, and the only tickets addressed so far are44
20
but I figured getting your thoughts on how far I've gotten (have a look at
CHANGELOG.md
, but can highlight stuff here as well if you like).If you'd also rather only merge to
main
when all changes for3.4
are achieved no worries, can create further branches for those changes but figured this might be a helpful start to review how it's going.