Living-with-machines / lwmdb

A django-based library for managing the Living with Machines newspapers metadata database schema
https://living-with-machines.github.io/lwmdb/
MIT License
2 stars 0 forks source link

Code review of `lib_metadata_db` codebase #50

Open kallewesterling opened 2 years ago

kallewesterling commented 2 years ago

(This issue was originally intended as a submission to the DH Code process for code review)

griff-rees commented 1 year ago

A starting point (of potential tickets...).

griff-rees commented 1 year ago

Might be worth having a peak at this @kallewesterling: maybe helpful agenda for a meeting. A significant refactor is done.

kallewesterling commented 1 year ago

Sorry @griff-rees - I had missed your comment here.

Re: this

Not sure how the django_initialiser module is used. I can see the value of its init.py in some contexts but wondering if those are still applicable.

It is needed to load Django inside of a Jupyter notebook. We used it this summer to make sure that django is correctly set up, etc. in the top line of the notebook:

import django_initialiser

Ideally, we'd have instructions for how to do this more explicitly for folks who want to work with Jupyter Notebooks/Lab + the metadata db eventually... It was just a shortcut so I wouldn't have to spend time on it this past summer.

griff-rees commented 1 year ago

Thanks @kallewesterling and sorry for not replying sooner. I think this form is what's necessary for this: https://docs.google.com/forms/d/e/1FAIpQLSeFLFSS2NEttNimGo-lZmDiSjWzcoefV8GojEZGHPd-YVtBkQ

griff-rees commented 1 year ago

I've created ticket #171 to address the first element on my list in the comment above