search

Living-with-machines / station-to-station

This repository provides underlying code and materials for the paper 'Station to Station: Linking and Enriching Historical British Railway Data'.
https://ceur-ws.org/Vol-2989/long_paper29.pdf
MIT License
5 stars 1 forks source link

Quicks wiki alignment #9

Closed mcollardanuy closed 3 years ago

review-notebook-app[bot] commented 3 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

GiorgiatolfoBL commented 3 years ago

@mcollardanuy I have commented out some xpaths + lines as they were duplicated, I'm not sure how to commit these and at the same time answer this pull request. Any chance we can do it together on monday on video? (sorry, still getting used to pull requests)

mcollardanuy commented 3 years ago

Hi @GiorgiatolfoBL! I have made the updates we've discussed, and the functions are now in a script called utils. Could you have a look? Thanks!

mcollardanuy commented 3 years ago

Great, thanks @GiorgiatolfoBL, you can see the changes here.