search

Livox-SDK / livox_ros_driver

Livox device driver under ros, support Lidar Mid-40, Mid-70, Tele-15, Horizon, Avia.
Other
352 stars 201 forks source link

"git" and "apr" listed as dependencies in package.xml #128

Open lrstttl opened 2 years ago

lrstttl commented 2 years ago

Hi everyone,

we noticed that the livox_ros_driver/package.xml contains <depend/> tags for git and apr.

However, they are not actually needed for building, so they are not build, export or execution dependencies (as documented in http://wiki.ros.org/catkin/package.xml for <depend/> tags).

We also run the following command in our CI pipeline to install all dependencies

rosdep install --from-paths src --ignore-src -r -y

to install all dependencies, but as git and apr are not resolved, they are still listed when running 

rosdep keys --from-paths src --ignore-src -r -y

So, is there a reason why the tools are listed in <depend/> tag?