LizardByte / Sunshine

Self-hosted game stream host for Moonlight.
http://app.lizardbyte.dev/Sunshine/
GNU General Public License v3.0
17.65k stars 855 forks source link

Nightly build completely broke controller support #1407

Closed lyndonguitar closed 10 months ago

lyndonguitar commented 1 year ago

Is there an existing issue for this?

Is your issue described in the documentation?

Is your issue present in the nightly release?

Describe the Bug

automated nightly release - 2023-06-28T02:12:10Z - https://github.com/LizardByte/Sunshine/commit/12e67740351fbeec495455e1509c9298a924720c

completely broke controller support, controllers are not calibrated anymore. reverting to latest stable version fixes it

Expected Behavior

Controller should work and should be properly calibrated

Additional Context

joysticks are wonky, buttons are wrongly mapped, not work as intended

Host Operating System

Windows

Operating System Version

Windows

Architecture

64 bit

Sunshine commit or version

automated nightly release - 2023-06-28T02:12:10Z - 12e6774

Package

Windows - installer

GPU Type

Nvidia

GPU Model

RTX 3080

GPU Driver/Mesa Version

535.98

Capture Method (Linux Only)

No response

Config

its empty

Apps

No response

Relevant log output

was not able to get it when it was not working
cgutman commented 1 year ago

We'll need more information about your setup.

What client version are you using? What controller is connected to your client? What controller do you have Sunshine set to emulate?

Which buttons and axes are not mapped correctly? What are those incorrectly mapped buttons/axes actually mapped to?

Lucide commented 1 year ago

Button mapping is scrambled at least from build 11aedf56a24cbf1e82f9699a39e4207346aefa5a.

The vertical left axis acts as the right horizontal axis, and the left horizontal acts as the left vertical axis. Basically the same as moonlight's !822. The d-pad and face buttons are ok.

This is different from the scrambled mappings of cabled-vs-bluetooth controllers found with certain games/situations (where the stick axis are fine but the shoulder buttons/axis and the d-pad are incorrect).

cgutman commented 1 year ago

Please test this build from #1426 which should fix the issue: https://github.com/LizardByte/Sunshine/suites/14124093845/artifacts/790595658

Lucide commented 1 year ago

Fixed in my use cases🙂

erictbar commented 1 year ago

I had the same issue and this test build fixed it for me

Host: Windows 11 Pro 22H2 22621.1928, Latest nightly of Sunshine Clients:

The game I noticed the issue with was Mass Effect Legendary Edition. Moving around with the L and R sticks was completely broken. When I went to controller settings in Windows and went to calibrate, I was able to get the Left controller to the upper left, but would not find the lower left.

Stono commented 1 year ago

Hey that link 404's for me so can't test it

ns6089 commented 1 year ago

Hey that link 404's for me so can't test it

https://github.com/LizardByte/Sunshine/actions/runs/5482586470?pr=1426 is semi-permanent link, select sunhine-windows artifact at the bottom of the screen

LizardByte-bot commented 1 year ago

This issue has been fixed and will be available in the next release.