ReenigneArcher
commented
7 months ago Well, it's listed as a "todo" in our docs.
Any devs who actually use macOS are welcome to submit a PR/fix.
Closed nenkoru closed 7 months ago
ReenigneArcher
commented
7 months ago Well, it's listed as a "todo" in our docs.
Any devs who actually use macOS are welcome to submit a PR/fix.
nenkoru
commented
7 months ago Apparently it is already implemented and works as expected. Albeit not making any output to the console. https://github.com/LizardByte/Sunshine/blob/bb7c2d50ef50bf5bca34c2b873c9cf74e0745baa/src/platform/macos/display.mm#L145C5-L156C6
I managed to enumerate all the displays using CGGetOnlineDisplayList by python bindings for the ease of debugging using the following code:
import Quartz
displays = Quartz.CoreGraphics.CGGetOnlineDisplayList(12, None, None)[1]
for display in displays:
print(display)It would print the ids of displays. Setting the output_name in a config file to the respective id makes it to work.
I am not sure what behaviour should be expected when the requested display does not exist, so I can't make a respective change to the code. But if you(@ReenigneArcher) could point this out -> I would happily make my first contribution to this beautiful project. =)
ReenigneArcher
commented
7 months ago Maybe this will get you started. https://github.com/LizardByte/Sunshine/blob/bb7c2d50ef50bf5bca34c2b873c9cf74e0745baa/src/video.cpp#L984
nenkoru
commented
7 months ago Closing as this does work, but needs to have more verbosity. Will create a PR soon referring to this issue.
Is there an existing issue for this?
Is your issue described in the documentation?
Is your issue present in the nightly release?
Describe the Bug
Changing output_name to another display's name does not change the display the stream is coming from.
Expected Behavior
Either an error should be produced saying a display is not found or the streaming should with a display explicitly defined in output_name config file.
Additional Context
Created a virtual display using another software which works fine. Wanted to stream the display to my tablet but sunshine still uses the default, main display of the laptop.
Host Operating System
macOS
Operating System Version
13.6.3 (22G436)
Architecture
arm
Sunshine commit or version
0.22.2
Package
other (self built)
GPU Type
none (software encoding)
GPU Model
M1 Pro
GPU Driver/Mesa Version
-
Capture Method (Linux Only)
-
Config
Apps
No response
Relevant log output