LizardByte / Sunshine

Self-hosted game stream host for Moonlight.
http://app.lizardbyte.dev/Sunshine/
GNU General Public License v3.0
15.41k stars 743 forks source link

fix(macos): fix boost on macos #2733

Closed Hazer closed 1 week ago

Hazer commented 1 week ago

Description

macOS has some issues with Boost linking, this PR fixes the runtime error when statically linking boost, fixes the dynamic macOS build missing -licudata (icu4c) and improves brew installation options.

Checklist

Type of Change

Checklist

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch must be updated before it can be merged. You must also Allow edits from maintainers.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 8.89%. Comparing base (acd9ae6) to head (94afcef).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2733 +/- ## ========================================= - Coverage 8.96% 8.89% -0.08% ========================================= Files 94 94 Lines 17392 17385 -7 Branches 8270 8270 ========================================= - Hits 1560 1546 -14 - Misses 12967 12973 +6 - Partials 2865 2866 +1 ``` | [Flag](https://app.codecov.io/gh/LizardByte/Sunshine/pull/2733/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LizardByte) | Coverage Δ | | |---|---|---| | [Linux](https://app.codecov.io/gh/LizardByte/Sunshine/pull/2733/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LizardByte) | `6.79% <ø> (ø)` | | | [Windows](https://app.codecov.io/gh/LizardByte/Sunshine/pull/2733/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LizardByte) | `4.16% <ø> (ø)` | | | [macOS-12](https://app.codecov.io/gh/LizardByte/Sunshine/pull/2733/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LizardByte) | `?` | | | [macOS-13](https://app.codecov.io/gh/LizardByte/Sunshine/pull/2733/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LizardByte) | `?` | | | [macOS-14](https://app.codecov.io/gh/LizardByte/Sunshine/pull/2733/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LizardByte) | `10.24% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LizardByte#carryforward-flags-in-the-pull-request-comment) to find out more. [see 4 files with indirect coverage changes](https://app.codecov.io/gh/LizardByte/Sunshine/pull/2733/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LizardByte)