LizardByte / Sunshine

Self-hosted game stream host for Moonlight.
http://app.lizardbyte.dev/Sunshine/
GNU General Public License v3.0
15.41k stars 743 forks source link

fix(upnp): Support miniupnpc API version 18 (release 2.2.8) #2746

Closed chewi closed 1 day ago

chewi commented 1 week ago

Description

The miniupnpc API has changed slightly. This allows both older and newer versions. The additional arguments are for returning data that Sunshine doesn't need to care about, so nullptr, 0 is sufficient. I have already made the same change to a couple of other projects.

Type of Change

Checklist

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch must be updated before it can be merged. You must also Allow edits from maintainers.

codecov[bot] commented 2 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 8.95%. Comparing base (90fd371) to head (09b7ac3).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2746 +/- ## ========================================= - Coverage 8.95% 8.95% -0.01% ========================================= Files 94 94 Lines 17383 17385 +2 Branches 8267 8267 ========================================= Hits 1557 1557 - Misses 12962 12967 +5 + Partials 2864 2861 -3 ``` | [Flag](https://app.codecov.io/gh/LizardByte/Sunshine/pull/2746/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LizardByte) | Coverage Δ | | |---|---|---| | [Linux](https://app.codecov.io/gh/LizardByte/Sunshine/pull/2746/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LizardByte) | `6.79% <ø> (ø)` | | | [Windows](https://app.codecov.io/gh/LizardByte/Sunshine/pull/2746/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LizardByte) | `4.16% <ø> (ø)` | | | [macOS-12](https://app.codecov.io/gh/LizardByte/Sunshine/pull/2746/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LizardByte) | `10.01% <ø> (-0.02%)` | :arrow_down: | | [macOS-13](https://app.codecov.io/gh/LizardByte/Sunshine/pull/2746/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LizardByte) | `9.92% <ø> (-0.01%)` | :arrow_down: | | [macOS-14](https://app.codecov.io/gh/LizardByte/Sunshine/pull/2746/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LizardByte) | `10.22% <ø> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LizardByte#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/LizardByte/Sunshine/pull/2746?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LizardByte) | Coverage Δ | | |---|---|---| | [src/upnp.cpp](https://app.codecov.io/gh/LizardByte/Sunshine/pull/2746?src=pr&el=tree&filepath=src%2Fupnp.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LizardByte#diff-c3JjL3VwbnAuY3Bw) | `2.98% <ø> (-0.04%)` | :arrow_down: | ... and [22 files with indirect coverage changes](https://app.codecov.io/gh/LizardByte/Sunshine/pull/2746/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LizardByte)