LizardByte / Sunshine

Self-hosted game stream host for Moonlight.
http://app.lizardbyte.dev/Sunshine/
GNU General Public License v3.0
15.41k stars 743 forks source link

fix(upnp): support newer miniupnpc library #2782

Closed ReenigneArcher closed 1 day ago

ReenigneArcher commented 2 days ago

Description

Fixes incompatibilities with newer version of miniupnpc library.

Screenshot

Issues Fixed or Closed

Type of Change

Checklist

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch must be updated before it can be merged. You must also Allow edits from maintainers.

codecov[bot] commented 2 days ago

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 8.99%. Comparing base (90fd371) to head (f39b8df).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2782 +/- ## ========================================= + Coverage 8.95% 8.99% +0.03% ========================================= Files 94 95 +1 Lines 17383 17385 +2 Branches 8267 8268 +1 ========================================= + Hits 1557 1564 +7 + Misses 12962 12957 -5 Partials 2864 2864 ``` | [Flag](https://app.codecov.io/gh/LizardByte/Sunshine/pull/2782/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LizardByte) | Coverage Δ | | |---|---|---| | [Linux](https://app.codecov.io/gh/LizardByte/Sunshine/pull/2782/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LizardByte) | `6.85% <0.00%> (+0.06%)` | :arrow_up: | | [Windows](https://app.codecov.io/gh/LizardByte/Sunshine/pull/2782/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LizardByte) | `4.16% <0.00%> (-0.01%)` | :arrow_down: | | [macOS-12](https://app.codecov.io/gh/LizardByte/Sunshine/pull/2782/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LizardByte) | `10.01% <0.00%> (-0.02%)` | :arrow_down: | | [macOS-13](https://app.codecov.io/gh/LizardByte/Sunshine/pull/2782/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LizardByte) | `9.92% <0.00%> (-0.01%)` | :arrow_down: | | [macOS-14](https://app.codecov.io/gh/LizardByte/Sunshine/pull/2782/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LizardByte) | `10.22% <0.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LizardByte#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/LizardByte/Sunshine/pull/2782?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LizardByte) | Coverage Δ | | |---|---|---| | [src/upnp.h](https://app.codecov.io/gh/LizardByte/Sunshine/pull/2782?src=pr&el=tree&filepath=src%2Fupnp.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LizardByte#diff-c3JjL3VwbnAuaA==) | `0.00% <0.00%> (ø)` | | | [src/upnp.cpp](https://app.codecov.io/gh/LizardByte/Sunshine/pull/2782?src=pr&el=tree&filepath=src%2Fupnp.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LizardByte#diff-c3JjL3VwbnAuY3Bw) | `3.01% <0.00%> (ø)` | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/LizardByte/Sunshine/pull/2782/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LizardByte)