Closed gongfuture closed 3 weeks ago
I seems found this part of code? https://github.com/LizardByte/Sunshine/blob/master/src/process.cpp#L155-L177 So it's just works in the app execution? Can we change its area of influence to the whole Sunshine? Or just all writable commands.
I seems found this part of code? https://github.com/LizardByte/Sunshine/blob/master/src/process.cpp#L155-L177 So it's just works in the app execution? Can we change its area of influence to the whole Sunshine? Or just all writable commands.
You can submit a PR adjusting them to work with global prep commands.
I seems found this part of code? https://github.com/LizardByte/Sunshine/blob/master/src/process.cpp#L155-L177 So it's just works in the app execution? Can we change its area of influence to the whole Sunshine? Or just all writable commands.
You can submit a PR adjusting them to work with global prep commands.
I want, but I have no C++ programming experience :(
I seems found this part of code? https://github.com/LizardByte/Sunshine/blob/master/src/process.cpp#L155-L177 So it's just works in the app execution? Can we change its area of influence to the whole Sunshine? Or just all writable commands.
You can submit a PR adjusting them to work with global prep commands.
No need, can confirm it already works with global prep commands because all of my scripts rely on that and can read the environment variables just fine.
In that case, probably need to prefix the commands with cmd /c
I seems found this part of code? https://github.com/LizardByte/Sunshine/blob/master/src/process.cpp#L155-L177 So it's just works in the app execution? Can we change its area of influence to the whole Sunshine? Or just all writable commands.
You can submit a PR adjusting them to work with global prep commands.
No need, can confirm it already works with global prep commands because all of my scripts rely on that and can read the environment variables just fine.
Did the latest release v0.23.1 had supported this? Or just newer pre-release had added this? If pre-release added, I will have a try. But if latest release had this feature, why the environment variables didn't parsed in my command of adding registry? I'm very confused.
upd: So it's just need to add cmd /c
, I'm so stupid
In that case, probably need to prefix the commands with
cmd /c
Thank you so much
Is there an existing issue for this?
Is your issue described in the documentation?
Is your issue present in the latest beta/pre-release?
None
Describe the Bug
Use environment variables in global preparation command. For example, change the virtual display resolution in register. It will only move like %SUNSHINE_CLIENT_HEIGHT% into the register.
Expected Behavior
It can correctly parse the variables to value.
Additional Context
Maybe it can work past, but I'm not sure. I haven't use sunshine for a time, and these days I reuse this and update it.
Host Operating System
Windows
Operating System Version
版本 Windows 10 Professional 专业版 版本号 22H2 安装日期 2023/1/13 操作系统内部版本 19045.4598 体验 Windows Feature Experience Pack 1000.19060.1000.0
Architecture
64 bit
Sunshine commit or version
Version v0.23.1
Package
Windows - installer
GPU Type
Nvidia
GPU Model
NVIDIA GeForce RTX 3060 Laptop GPU
GPU Driver/Mesa Version
556.12
Capture Method
None
Config
Apps
No response
Relevant log output