ReenigneArcher
commented
8 months ago Regarding the modification to the quote, I think we'd need something more robust than that. It's unlikely that Chinese characters are the only ones with issues.
This is the function we're currently using. https://github.com/squaresmile/Plex-Plug-Ins/blob/fc4ab34d4cb995668abd84b304b57c5bf13cb69d/Framework.bundle/Contents/Resources/Versions/2/Python/Framework/api/utilkit.py#L229
If we're going to move to a non framework method, we should probably use urllib3 instead of urllib.
Regarding why it doesn't work after you adjust the quoting, the reason is the results are returning in English, but your query is in Chinese.
for result in tmdb_data['results']:
if result['name'].lower() == search_query.lower() or \
'{} {}'.format(search_query.lower(), end_string).lower() == result['name'].lower():
collection_id = int(result['id'])Your result['name].lower() is james bond collection, but your search_query is 詹姆斯·邦德 (not sure what the lowercase version of that is, or if you even have lowercase letters in Chinese). So ultimately, the collection_id is not being set.
@zdimension didn't you confirm that collections are working for you in French? Is Plex returning the TMDB results in French for you in this case?
x1ao4
Describe the Bug
When using the original version of
tmdb_helper.py, Chinese titled collections cannot retrieve corresponding TMDB data. Here's an example of the log:After testing, I found that the issue lies with URL encoding. Since collections are searched and matched on TMDB using their titles, the original script uses the
String.Quotefunction which utilizes Unicode escape sequence URL encoding. For example, "黑夜传说（系列）" would be encoded as:I made some modifications to the script. Now, when the title is in Chinese, it uses the
urllib.quotefunction with UTF-8 encoding for URL encoding. For titles in other languages, the script still uses theString.Quotefunction. For example, "黑夜传说（系列）" would now be encoded as:The modified
tmdb_helper.pyis as follows:After the modification, TMDB data for collections with Chinese titles can now be retrieved. For example:
However, collections with Chinese titles still cannot fetch theme songs, while collections with English titles can. For example, I have one collection titled "James Bond Collection" and another titled "詹姆斯·邦德（系列）" in two separate libraries. The collection with the English title successfully fetched the theme song, but the one with the Chinese title did not.
I'm not sure if there are notifications in the logs for fetching theme songs for collections because I haven't seen any "data found for collection" notifications while monitoring the logs. It might be challenging to filter logs based on this. However, in the WebUI, I noticed that only collections in the English library fetched theme songs, while collections in the Chinese library did not. I hope we can find the reason for this discrepancy.
Furthermore, even though we've retrieved data from TMDB, the collection IDs in the logs still show as None. Is this normal? Also, in the WebUI, it displays as "No known ID," despite some collections having successfully matched data from TMDB.
I'm puzzled as well. Both collections with Chinese and English titles have successfully matched with TMDB. So, it's unclear why only collections with English titles are fetching theme songs. There might be a specific issue or limitation in the retrieval process that's causing this discrepancy. It could be worth investigating further to understand the root cause.
How does Themerr search and match collections in ThemerrDB? Is the issue possibly occurring here?
Expected Behavior
No response
Additional Context
No response