LizardByte / Themerr-plex

Plugin for Plex Media Server that adds theme songs to movies using ThemerrDB.
https://app.lizardbyte.dev/ThemerrDB
GNU Affero General Public License v3.0
71 stars 4 forks source link

fix(collections): use library language in tmdb query #395

Closed ReenigneArcher closed 7 months ago

ReenigneArcher commented 7 months ago

Description

Screenshot

Issues Fixed or Closed

Type of Change

Checklist

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch must be updated before it can be merged. You must also Allow edits from maintainers.

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 71.48%. Comparing base (f1a3948) to head (f290ff4).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #395 +/- ## ========================================== - Coverage 71.52% 71.48% -0.04% ========================================== Files 12 12 Lines 1085 1087 +2 ========================================== + Hits 776 777 +1 - Misses 309 310 +1 ``` | [Flag](https://app.codecov.io/gh/LizardByte/Themerr-plex/pull/395/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LizardByte) | Coverage Δ | | |---|---|---| | [Linux](https://app.codecov.io/gh/LizardByte/Themerr-plex/pull/395/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LizardByte) | `71.48% <50.00%> (-0.04%)` | :arrow_down: | | [Windows](https://app.codecov.io/gh/LizardByte/Themerr-plex/pull/395/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LizardByte) | `71.48% <50.00%> (-0.04%)` | :arrow_down: | | [macOS](https://app.codecov.io/gh/LizardByte/Themerr-plex/pull/395/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LizardByte) | `71.48% <50.00%> (-0.04%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LizardByte#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/LizardByte/Themerr-plex/pull/395?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LizardByte) | Coverage Δ | | |---|---|---| | [Contents/Code/tmdb\_helper.py](https://app.codecov.io/gh/LizardByte/Themerr-plex/pull/395?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LizardByte#diff-Q29udGVudHMvQ29kZS90bWRiX2hlbHBlci5weQ==) | `82.97% <100.00%> (+0.37%)` | :arrow_up: | | [Contents/Code/plex\_api\_helper.py](https://app.codecov.io/gh/LizardByte/Themerr-plex/pull/395?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LizardByte#diff-Q29udGVudHMvQ29kZS9wbGV4X2FwaV9oZWxwZXIucHk=) | `53.33% <0.00%> (-0.17%)` | :arrow_down: |
ReenigneArcher commented 7 months ago

@x1ao4 Could you give this PR another test?

x1ao4 commented 7 months ago

It worked, I got the collection theme songs with Chinese titles, well done!

ReenigneArcher commented 7 months ago

@x1ao4 Great, thank you for testing! Next issue is getting the settings page localized.