fix(yt-dl): validate audio url and add retry logic

ReenigneArcher commented 3 months ago

Description

After merging #481 there are issues with YouTube urls.

It seems the urls provided by youtube are inaccessible due to 403 errors. When these are sent to Plex, a 406 response is given. See https://github.com/ytdl-org/youtube-dl/issues/32882 for more info.

Some retry logic was added.
Improved unit tests.

Screenshot

Issues Fixed or Closed

Type of Change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Dependency update (updates to dependencies)
[ ] Documentation update (changes to documentation)
[ ] Repository update (changes to repository files, e.g. .github/...)

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch must be updated before it can be merged. You must also Allow edits from maintainers.

[ ] I want maintainers to keep my branch updated

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 31.66667% with 41 lines in your changes missing coverage. Please review.

Project coverage is 69.55%. Comparing base (29d0e8e) to head (e71e641). Report is 2 commits behind head on master.

Files with missing lines	Patch %	Lines
Contents/Code/youtube_dl_helper.py	32.20%	40 Missing :warning:
Contents/Code/plex_api_helper.py	0.00%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #486 +/- ## ========================================== + Coverage 67.98% 69.55% +1.56% ========================================== Files 12 12 Lines 1087 1120 +33 ========================================== + Hits 739 779 +40 + Misses 348 341 -7 ``` | [Flag](https://app.codecov.io/gh/LizardByte/Themerr-plex/pull/486/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LizardByte) | Coverage Δ | | |---|---|---| | [Linux](https://app.codecov.io/gh/LizardByte/Themerr-plex/pull/486/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LizardByte) | `68.92% <31.66%> (+0.94%)` | :arrow_up: | | [Windows](https://app.codecov.io/gh/LizardByte/Themerr-plex/pull/486/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LizardByte) | `68.92% <31.66%> (+0.94%)` | :arrow_up: | | [macOS](https://app.codecov.io/gh/LizardByte/Themerr-plex/pull/486/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LizardByte) | `69.55% <31.66%> (+1.56%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LizardByte#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/LizardByte/Themerr-plex/pull/486?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LizardByte) | Coverage Δ | | |---|---|---| | [Contents/Code/default\_prefs.py](https://app.codecov.io/gh/LizardByte/Themerr-plex/pull/486?src=pr&el=tree&filepath=Contents%2FCode%2Fdefault_prefs.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LizardByte#diff-Q29udGVudHMvQ29kZS9kZWZhdWx0X3ByZWZzLnB5) | `100.00% <ø> (ø)` | | | [Contents/Code/plex\_api\_helper.py](https://app.codecov.io/gh/LizardByte/Themerr-plex/pull/486?src=pr&el=tree&filepath=Contents%2FCode%2Fplex_api_helper.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LizardByte#diff-Q29udGVudHMvQ29kZS9wbGV4X2FwaV9oZWxwZXIucHk=) | `55.15% <0.00%> (+6.06%)` | :arrow_up: | | [Contents/Code/youtube\_dl\_helper.py](https://app.codecov.io/gh/LizardByte/Themerr-plex/pull/486?src=pr&el=tree&filepath=Contents%2FCode%2Fyoutube_dl_helper.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LizardByte#diff-Q29udGVudHMvQ29kZS95b3V0dWJlX2RsX2hlbHBlci5weQ==) | `39.25% <32.20%> (-2.64%)` | :arrow_down: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/LizardByte/Themerr-plex/pull/486/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LizardByte)