TriangleAuthority
commented
8 years ago https://github.com/TriangleAuthority/BetterCombatEvolved/pull/1/files
here are my changes for heavy attack damage calculation. should be a lot more straightforward now. If you don't want to use the menu slider, just change those lines to grab an attribute from xml instead (eg a custom 'total_damage_mod' attribute in the heavy attack skill in geralt_skills.xml). Geralt's heavy attacks will be a straightforward damage multiplier, and will be reflected in the stats page.
Lknechtli
There's some weird shit with heavy attacks.
After calculating attack power bonuses, the game subtracts 0.833 from attack power, and then later multiplies the final damage by 1.833. Weird. Also weird is that, when displaying heavy attack power in the stats page, it hardcodes a 1.833 bonus, not including the -0.833 subtraction that happens in practice, and also not including the geralt_skills.xml heavy attack bonus. So it is pretty much always incorrect.
Just a heads up. I think I'll be fixing this next, and hopefully changing more with heavy and light attacks. I'll remove the weirdness and hardcoded-ness. I think this will affect NPC heavy attacks as well, so I will have to do some testing. Should make damage calculation a bit more transparent! I traced through how damage is calculated today (at least for geralt), so I think I have a better grasp.
As for other attack changes I want to do, I think I'll be lengthening hit stun/stagger from heavy attacks, maybe adding status effects to heavy attack crits, and gradually increasing damage with successive light attacks (combos!). Probably tied to muscle mem and strength training.
Generally want to make heavy attacks more fun/useful (don't want to just pump damage until they are mathematically better than fast attacks). Also considering some fancy stuff with rend. eg effects based on number of adrenaline points used, knockdown on group enemies, etc. Unfortunately can't think of anything cool to do with whirl :/