Llama-Logic / PlumbBuddy

The friendly helper for Sims 4 mods—crafted with care, open for all.
MIT License
0 stars 0 forks source link

Limit of the number of scan issues to mention in a notification #2

Closed BigBadBleuCheese closed 4 hours ago

BigBadBleuCheese commented 5 hours ago

Exacerbated by #1 but still, no matter how many scan issues PB has, it should never be popping off this much. image

Curious about what @amethystlilac thinks should be the limiting factor here.

amethystlilac commented 5 hours ago

If it's possible to say something like 'I found a ZIP file: x.zip and others,' I'd say limit to one per scan type. Otherwise, maybe 6 or so? Enough to encourage people to check, but not enough to take up your whole screen and still run out of space.

BigBadBleuCheese commented 5 hours ago

If it's possible to say something like 'I found a ZIP file: x.zip and others,' I'd say limit to one per scan type. Otherwise, maybe 6 or so? Enough to encourage people to check, but not enough to take up your whole screen and still run out of space.

Looking at your screenshot, what I'm thinking is:

My reasoning here is that it seems like that would fit in the notification. I'd really prefer to avoid truncating.

amethystlilac commented 4 hours ago

That's reasonable. Users would know that there are multiple issues, but the notification was so big that if I didn't know what I was doing to cause it, it would have been overwhelming instead of funny.

BigBadBleuCheese commented 4 hours ago

What do you think? image

amethystlilac commented 4 hours ago

Looks good. Not too big but still makes it clear there are multiple issues