search

LlamaEdge / rag-api-server

A RAG API server written in Rust following OpenAI specs
https://llamaedge.com/docs/user-guide/server-side-rag/quick-start
Apache License 2.0
31 stars 8 forks source link

Redundant RUSTFLAGS in release.yml? #23

Open suryyyansh opened 2 months ago

suryyyansh commented 2 months ago

Are the RUSTFLAGS in release.yml still required after the addition of the .cargo folder?

suryyyansh commented 2 months ago

@apepkuss Could I get an update for this. Thanks.

apepkuss commented 2 months ago

Sorry for the late reply! Please do not update the release workflow, in case there is any bad effect on the releases. For the potential issue you mentioned above, we'll check it and update the workflow if necessary. Thanks a lot!

suryyyansh commented 2 months ago

I understand, but wouldn't it make sense to have an additional release asset for the search enabled rag-api-server? since it requires recompilation with the search feature to be used.

This is what I was going to include in my PR. Let me know what you think.

juntao commented 2 months ago

Yes. I agree that we need release assets for the search-api-server.