search

LlamaLad7 / MixinExtras

Companion library to SpongePowered Mixin with many custom injectors for a more expressive experience.
MIT License
293 stars 16 forks source link

`SugarApplicationException`s aren't passed to `IMixinErrorHandler` #46

Closed melontini closed 10 months ago

melontini commented 10 months ago

While testing IMixinErrorHandler on Connector, I noticed that Sugar exceptions aren't passed to the handler.

The Mixin in question: [link]

The IMixinErrorHandler in question: [link]

LlamaLad7 commented 10 months ago

IMixinErrorHandler is very broken generally, e.g. no injection check failures get passed to it. Do you have a particular need for sugar exceptions to be passed to it exclusively? If the underlying behaviour in mixin were improved you would be able to get them by looking at the suppressed exceptions from the injection check failure.

melontini commented 10 months ago

Ah, wasn't aware of issues with the handler, thank you. (I guess this is what https://github.com/SpongePowered/Mixin/pull/640 is about?)

Anyway, there's no particular need for sugar exceptions. I just assumed this was something to do with sugar exclusively. Sorry.

I'll close this, as this is not an issue with MixinExtras.

LlamaLad7 commented 10 months ago

Yeah, that getting merged would be ideal.