search

LlamaLad7 / MixinExtras

Companion library to SpongePowered Mixin with many custom injectors for a more expressive experience.
MIT License
309 stars 17 forks source link

Insufficient maximum stack size when using @Local #59

Closed kappa-maintainer closed 9 months ago

kappa-maintainer commented 9 months ago

I am porting Sound-Physics to Mixin since its ASM code can't handle newer IC2C anymore. The up-to-date code of my fork is located at here. When loading my build in actual game environment with mixin.debug set to true, this error throwed: 2023-12-14-5.log.gz I realized this may cause by MixinBooter not using latest MixinExtra, so I rebuilt it with latest MixinExtra (jar), but end up getting different exceptions (log:2023-12-14-7.log.gz) Since every failed mixin is using @Local, I assume it's better to report here.

LlamaLad7 commented 9 months ago

I'm gonna say just don't use -Dmixin.debug=true. This has never been recommended since it enables a bunch of stuff you don't want, like -Dmixin.debug.verify=true which has absolutely no benefit to you and disabling would avoid the issue. While I could "fix" it on my end, this is kind of a bug in ASM and since ASM 9 it doesn't occur so legacy forge is basically the only platform affected, so I'm hesitant to fix it. Just enable the specific things from https://github.com/SpongePowered/Mixin/wiki/Mixin-Java-System-Properties that you actually want.

kappa-maintainer commented 9 months ago

Thanks, I originally thought those mixins didn't get injected