LlamaSwap / interface

Frontend for LlamaSwap
https://swap.defillama.com
85 stars 77 forks source link

add 0x gasless swaps #266

Closed mintdart closed 5 months ago

vercel[bot] commented 6 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
llamaswap ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2024 11:28am
cloudflare-workers-and-pages[bot] commented 6 months ago

Deploying llamaswap with  Cloudflare Pages  Cloudflare Pages

Latest commit: c193332
Status: ✅  Deploy successful!
Preview URL: https://c367968b.llamaswap.pages.dev
Branch Preview URL: https://0x-gasless.llamaswap.pages.dev

View logs

mintdart commented 6 months ago

will this work for tokens like USDT that don't have EIP712 support? doesn't look like it, but matcha supports it

I tested a swap from USDT to DAI on polygon, their api doesn't return any signature errors

Right now my test swap fails because of order not fillable , will try to swap on mainnet

Screenshot
mintdart commented 6 months ago

main thing missing is to separate the approval process, so its in two steps (rather than 2 popups that pop automatically) and user can choose whether to approve infinite or approve only amount needed in permits

updated

mintdart commented 6 months ago

minor comments, besides that leaving here two reminders for when it goes live:

  • need to set it as one of those adapters where we query our backend always
  • move api key to env var & replace it

also, is it possible to cancel 0x gasless orders like how you can cancel cowswap ones?

updated code to query our backend always and use api key in env var

currently it's not possible to cancel orders by external party

mintdart commented 5 months ago

hmm no retries on pending txs? or did i miss it?

added in https://github.com/LlamaSwap/interface/pull/266/commits/993f58be9f545773be21bd41b4feb864987f63ce