search

Llamabagel / transpo-android

Route 613 Android app (re-write)
MIT License
1 stars 2 forks source link

Feature/trips/tests #58

Closed dellisd closed 5 years ago

dellisd commented 5 years ago

Checklist

Issues

Fixes #57

Summary

Added tests for currently-used TripsRepository methods Coroutine Dispatchers are now injected into the repository Added codecov to Circle config

GetSelectedRouteTripsUseCase is incomplete and tests will be added later @dellisd

codecov-io commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@408f427). Click here to learn what that means. The diff coverage is 60.71%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master     #58   +/-   ##
========================================
  Coverage          ?   8.81%           
========================================
  Files             ?      57           
  Lines             ?     635           
  Branches          ?      82           
========================================
  Hits              ?      56           
  Misses            ?     569           
  Partials          ?      10
Impacted Files Coverage Δ
...l/transpo/ui/trips/GetSelectedRouteTripsUseCase.kt 0% <0%> (ø)
...mabagel/transpo/ui/trips/GetNextBusTripsUseCase.kt 81.81% <100%> (ø)
...java/ca/llamabagel/transpo/data/TripsRepository.kt 58.06% <40%> (ø)
...bagel/transpo/data/CoroutinesDispatcherProvider.kt 80% <80%> (ø)
.../ca/llamabagel/transpo/di/TransitDatabaseModule.kt 66.66% <85.71%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 408f427...c3e3cd5. Read the comment docs.

GustavoSanMartin commented 5 years ago

Also look at the codecov diff, you're missing a couple tests.

dellisd commented 5 years ago

Some tests aren't being written until those methods are finalized and actually used. (SharedPreference stuff mainly)

GustavoSanMartin commented 5 years ago

What about GetSelectedRouteTripsUseCase?

dellisd commented 5 years ago

I mentioned it in the commit message for f71bb70ca02049408ba76c1f0dea194cb7e4668b that I wouldn't be adding it until later because that api may change. It isn't currently in use.

GustavoSanMartin commented 5 years ago

Ah ok, maybe add a note in the pr comment pointing this out?