search

Llamabagel / transpo-android

Route 613 Android app (re-write)
MIT License
1 stars 2 forks source link

Upgrade to SDK 29 #60

Closed dellisd closed 5 years ago

dellisd commented 5 years ago

Upgrade to SDK 29 Upgrade dependencies (espeically retrofit 2.6 and okhttp 4.0). All methods were converted from return Deferred to being suspend functions. Migrate to kotlin dsl for gradle Re-enable ktlint. Added to Circle checks Update circle config for sdk 29

Continuing #50

Checklist

codecov[bot] commented 5 years ago

Codecov Report

Merging #60 into master will increase coverage by 0.05%. The diff coverage is 54.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #60      +/-   ##
==========================================
+ Coverage   12.83%   12.89%   +0.05%     
==========================================
  Files          60       60              
  Lines         662      659       -3     
  Branches      102      102              
==========================================
  Hits           85       85              
+ Misses        551      548       -3     
  Partials       26       26
Impacted Files Coverage Δ
.../main/java/ca/llamabagel/transpo/di/TripsModule.kt 0% <ø> (ø) :arrow_up:
...c/main/java/ca/llamabagel/transpo/di/DataModule.kt 0% <ø> (ø) :arrow_up:
...l/transpo/ui/trips/adapter/SingleTripViewHolder.kt 0% <ø> (ø) :arrow_up:
...va/ca/llamabagel/transpo/ui/trips/TripsActivity.kt 0% <ø> (ø) :arrow_up:
...bagel/transpo/ui/search/GetSearchResultsUseCase.kt 100% <ø> (ø) :arrow_up:
...a/llamabagel/transpo/ui/trips/TripsMapViewModel.kt 0% <ø> (ø) :arrow_up:
...abagel/transpo/ui/trips/adapter/TripAdapterItem.kt 28.57% <ø> (ø) :arrow_up:
...agel/transpo/ui/search/viewholders/SearchResult.kt 33.33% <ø> (ø) :arrow_up:
...nspo/ui/search/viewholders/SearchStopViewHolder.kt 0% <ø> (ø) :arrow_up:
...java/ca/llamabagel/transpo/data/TripsRepository.kt 58.06% <0%> (ø) :arrow_up:
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3b43dbf...c660a3d. Read the comment docs.